Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles: use mixin for Image styles in Image and RichText component #1241

Open
justintemps opened this issue Oct 3, 2024 · 0 comments
Open
Labels
2024:17 Release by 1 October

Comments

@justintemps
Copy link
Member

Right now, we're basically copying the Image styles in the RichText component to style its images.

You can see this done here: a9a1b77

This is not a good solution, instead we should use a mixin and import it in both places, the way we do with _breadcrumb.scss in _richtext.scss. That way, the styled will be kept in sync in both places.

@justintemps justintemps added the 2024:17 Release by 1 October label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024:17 Release by 1 October
Projects
None yet
Development

No branches or pull requests

1 participant