Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search option to sub-site nav #1206

Open
inesdgomes opened this issue Sep 12, 2024 · 7 comments
Open

Add search option to sub-site nav #1206

inesdgomes opened this issue Sep 12, 2024 · 7 comments
Assignees
Labels

Comments

@inesdgomes
Copy link
Collaborator

The sub-site nav does not currently support search. @beatrizmartinmartins Could you please review the component in order to integrate the search button? See here the use case for this: https://www.figma.com/design/ulu2zb7ZOuT4VXu4M7Yp98?node-id=4-3061#940888322

@justintemps
Copy link
Member

@inesdgomes and @beatrizmartinmartins just to add that for the time being, I think it should just be a link to a search page. Must subsites don't need their own keyword search.

@beatrizmartinmartins
Copy link
Collaborator

@justintemps @inesdgomes If we add a link to the search bar, we will need one more Menu Item, and we dont really have that much space on tablet. If we add the Menu Item of the Search bar (icon only), we don't need to use that much space. See the options here

@inesdgomes
Copy link
Collaborator Author

Hi @beatrizmartinmartins and @justintemps I think the search option is too hidden, though I also think you did what's possible, Beatriz. The issue here is that the current design for sub-sites nav creates too many limitations and I don't think it'll cover all of our needs. I'm wondering whether we shouldn't completely rethink the nav for subsites? I'll create a separate ticket for this.

Let's put this task on hold for now.

@inesdgomes
Copy link
Collaborator Author

inesdgomes commented Sep 24, 2024

Hi @justintemps As discussed, we'll have another variant of the header for more complex sub-sites, so I think Beatriz's proposal works. Can we sign this off?

@beatrizmartinmartins Please see my comment here: https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf?node-id=3979-7043#958928737 Also, let's always say 'Sub-site name' instead of 'Sub-brand'. Thanks

@beatrizmartinmartins
Copy link
Collaborator

All design related comments are done. @inesdgomes

@inesdgomes
Copy link
Collaborator Author

Hi @justintemps As discussed, we'll have another variant of the header for more complex sub-sites, so I think Beatriz's proposal works. Can we sign this off?

@beatrizmartinmartins Please see my comment here: https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf?node-id=3979-7043#958928737 Also, let's always say 'Sub-site name' instead of 'Sub-brand'. Thanks

Hi @justintemps This is with you for review.

@justintemps
Copy link
Member

Hi @inesdgomes , I don't think this is ready for dev yet. I see two local nav variants and it's unclear to me which one we should be working on here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants