Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull quote: Allow for white background #1029

Closed
inesdgomes opened this issue May 21, 2024 · 10 comments
Closed

Pull quote: Allow for white background #1029

inesdgomes opened this issue May 21, 2024 · 10 comments
Assignees
Labels
2024:15 Release by 3 September 2024:16 Release by 17 Sept 2024 2024:17 Release by 1 October design

Comments

@inesdgomes
Copy link
Collaborator

inesdgomes commented May 21, 2024

The pull quote needs to have an alternative background colour. When it's used on a light blue background, the grey on light blue does not work well.

Screenshot 2024-03-12 at 16 27 14

@beatrizmartinmartins Could you please adjust the component so it supports a white background too?
https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf/ILO-Components-Library?node-id=6340-11230&t=R3lyZzK9MNs9dofF-0

@beatrizmartinmartins
Copy link
Collaborator

@inesdgomes changes the background and also the line on the bottom so it had a little bit more contrast with light blue backgrounds. Check the component here

@inesdgomes
Copy link
Collaborator Author

Thanks @beatrizmartinmartins. @justintemps One more small fix: we need to add white as an alternative color for the blockquote. Right now it only supports grey. See component here: https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf/ILO-Components-Library?node-id=1433-3559&t=PQqpg8iCWbPVgCjB-0

@inesdgomes inesdgomes added the 2024:15 Release by 3 September label Aug 20, 2024
@justintemps
Copy link
Member

@inesdgomes and @beatrizmartinmartins, the pull quote isn't developed as a standalone component, should it be? Right now it's simply a style applied to the html

element in the RichText component, which doesn't take any settings.

The best solution in that case, I think, is to make the RichText component "themable" so you can decide how it looks on light and dark backgrounds. I don't think we can implement a solution that effects the blockquote alone.

@inesdgomes
Copy link
Collaborator Author

Hi @beatrizmartinmartins Justin and I discussed this. Adding another colour setting to the blockquote would not have an ideal development solution, so Justin suggested we use one single colour that works both on a white and light blue rich text. I was thinking perhaps we could change the grey to light blue - then when the quote is used on a white rich text, it'll have a light blue rectangle; when the quote is used on light blue rich text, it won't show any rectangle. What do you think?

@inesdgomes inesdgomes removed their assignment Aug 22, 2024
@beatrizmartinmartins
Copy link
Collaborator

@inesdgomes I made some tests. I think on white looks good, but on light blue background it just gets lost. Why would we have problems on implementing two colored pull quotes?

@inesdgomes
Copy link
Collaborator Author

@justintemps? Any chance you could reconsider this?

@justintemps
Copy link
Member

Hey @beatrizmartinmartins the pull quote isn't it's own component, it's part of the RichText component which applies styles to a lot of html elements that it might contain. We don't want to add a setting to the RichText component that only applies to the

element. At this phase, we'd prefer making a simple change to the blockquote that allows us to solve this issue without adding new settings.

@justintemps justintemps added the 2024:16 Release by 17 Sept 2024 label Sep 3, 2024
@beatrizmartinmartins
Copy link
Collaborator

@justintemps got it. Let's keep the light blue version then. Please see it here. cc @inesdgomes

@inesdgomes
Copy link
Collaborator Author

@justintemps Small changes needed here. See designs.

@justintemps
Copy link
Member

Moving this to dev in #1283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024:15 Release by 3 September 2024:16 Release by 17 Sept 2024 2024:17 Release by 1 October design
Projects
None yet
Development

No branches or pull requests

3 participants