Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail squid process with more obvious message when it fails to construct processor instance #44

Open
bvotteler opened this issue Dec 21, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers prio:medium

Comments

@bvotteler
Copy link
Contributor

When squid runs into an exception during the construction of the processor instance (as it did with failures to interpret updated metadata in the past), it quits with an unclear message. Our infrastructure will automatically restart it, so it will fail again in a loop.

When looking at the logs, it wasn’t immediately obvious that the process is in a crash-loop as this happened. The messages could simply be interpreted as some error that is non-fatal, caught and logged.

Therefore the task is:
Catch those exceptions and explicitly log that the process will be terminating before rethrowing (or doing a process.exit() or similar) so it is clear that squid is shutting down.

@bvotteler bvotteler added enhancement New feature or request prio:high labels Dec 21, 2022
@nud3l nud3l added this to Backlog Jan 3, 2023
@nud3l nud3l moved this to Todo ⏳ in Backlog Jan 3, 2023
@bvotteler bvotteler added good first issue Good for newcomers prio:medium and removed prio:high labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers prio:medium
Projects
Status: Todo
Development

No branches or pull requests

1 participant