Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge service crate into vault #411

Closed
gregdhill opened this issue Nov 8, 2022 · 2 comments · Fixed by #506
Closed

Merge service crate into vault #411

gregdhill opened this issue Nov 8, 2022 · 2 comments · Fixed by #506
Assignees
@nakul1010

Comments

@gregdhill
Copy link
Member

It is only ever consumed by the Vault binary so it doesn't make sense to keep separate. Also if / when we merge this we can combine the Error types for some simplification (discussed here).

Possibly related: #407
@nud3l nud3l added this to Backlog Jan 3, 2023
@nud3l nud3l moved this to Todo ⏳ in Backlog Jan 3, 2023
@nakul1010
Copy link
Member

@gregdhill The service crate is not only used in the vault but also used in faucet crate. Hence do u recommend it to move it in runtime or keep the crate separate itself?

@gregdhill
Copy link
Member Author

@nakul1010 the faucet crate only uses a few of the helpers (on_shutdown and wait_or_shutdown) let's duplicate those for now and see if we can optimize afterward.

@nakul1010 nakul1010 mentioned this issue Jul 27, 2023
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from Todo ⏳ to Done ✅ in Backlog Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nakul1010 nakul1010

Labels
None yet
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: merge service crate interlay/interbtc-clients
2 participants
@gregdhill @nakul1010