Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust SingleFilterSearchRequest Interface for 'IN' Operator to Require Array Type #453

Open
kang8 opened this issue Dec 23, 2024 · 0 comments · May be fixed by #454
Open

Adjust SingleFilterSearchRequest Interface for 'IN' Operator to Require Array Type #453

kang8 opened this issue Dec 23, 2024 · 0 comments · May be fixed by #454

Comments

@kang8
Copy link

kang8 commented Dec 23, 2024

Description:

Currently, the SingleFilterSearchRequest interface in the intercom-node library does not enforce that the value property be an array when the operator is set to "IN" or "NIN". This can lead to runtime errors if a string is provided instead of an array.

Proposed Solution:

Modify the SingleFilterSearchRequest interface to ensure type safety by differentiating between operators that require an array for value and those that do not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kang8