Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AuditLogEventType 130, 131, 132 missing #1600

Open
4 tasks done
LightD31 opened this issue Jan 27, 2024 · 8 comments
Open
4 tasks done

[BUG] AuditLogEventType 130, 131, 132 missing #1600

LightD31 opened this issue Jan 27, 2024 · 8 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers pending Pending approve

Comments

@LightD31
Copy link

LightD31 commented Jan 27, 2024

Library Version

5.11.0

Describe the Bug

Class AuditLogEventType received an invalid and unexpected value 130, a new enum item will be created to represent this value. Please update interactions.py or report this issue on GitHub - https://github.com/interactions-py/interactions.py/issues

Steps to Reproduce

130 = Add a sound to the soundboard
131 = Modify a sound in the soundboard
132 = Delete a sound from the soundboard

Expected Results

AuditLogeventType should recognize these

Minimal Reproducible Code

No response

Traceback

No response

Checklist

  • I have searched the open issues for duplicates.
  • I have shown the entire traceback, if possible.
  • I have removed my token from display, if visible.
  • I have attempted to debug this myself, and I believe this issue is with the library

Additional Information

No response

@Bastien1533
Copy link
Contributor

I can look into that 🙋‍♂️

@Bastien1533
Copy link
Contributor

Seems like an undocumented part of the api, I can suggest names for the events to wait the official implémentation.
None of the less it is an easy fix.

@LightD31
Copy link
Author

It's because it's undocumented that I made an issue report instead of a PR

@Bastien1533
Copy link
Contributor

Okay I see, maybe we could use like SOUNDBOARD_CREATE,SOUNDBOARD_EDIT and SOUNDBOARD_DELETE in the meantime.

@AstreaTSS
Copy link
Member

If it's undocumented, the usual thing to do is to simply not add anything until it is. We've ran into issues in the past where we named something too early and would have to do a breaking change to rename it.

@Bastien1533
Copy link
Contributor

Okay, then we hold that issue for now.

@eightween eightween added bug Something isn't working enhancement New feature or request good first issue Good for newcomers pending Pending approve labels Feb 3, 2024
@eightween
Copy link
Member

Setting this issue to pending until documentation exists for the new enumerations.

@RocketS2
Copy link

Should this issue still be pending? It looks like the documentation has been added here: https://discord.com/developers/docs/resources/audit-log#audit-log-entry-object-audit-log-events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers pending Pending approve
Projects
None yet
Development

No branches or pull requests

5 participants