Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event action consuming. #1367

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BalaBalaYi
Copy link
Collaborator

What changes were proposed in this pull request?

  1. To make sure hang event will be consumed by job manager, and the event will ouput.
  2. Improve logging level.
  3. Update NodeTopologyMeta parent class to JsonSerializable.

Why are the changes needed?

Bug fix.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT and training(with metric mock).

@BalaBalaYi BalaBalaYi added the bug Something isn't working label Nov 29, 2024
@BalaBalaYi BalaBalaYi added this to the v0.4.0 milestone Nov 29, 2024
@BalaBalaYi BalaBalaYi self-assigned this Nov 29, 2024
Copy link
Collaborator

@workingloong workingloong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants