Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct log and complete ut for error_monitor #1347

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jlsong01
Copy link
Contributor

What changes were proposed in this pull request?

code enhancement

Why are the changes needed?

  1. make log output more clear, since in k8s world you can ONLY mark a worker NODE unschedulable, while not a POD.

  2. complete the unit test for error monitor

Does this PR introduce any user-facing change?

no

How was this patch tested?

pre-commit test and unittest passed

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (d2ea4a7) to head (e909a9c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
dlrover/python/master/monitor/error_monitor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1347   +/-   ##
=======================================
  Coverage   81.13%   81.14%           
=======================================
  Files         231      231           
  Lines       21988    21989    +1     
=======================================
+ Hits        17840    17842    +2     
+ Misses       4148     4147    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalaBalaYi BalaBalaYi added the enhancement New feature or request label Nov 27, 2024
@BalaBalaYi BalaBalaYi added this to the v0.4.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants