Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port test_min_dot_size to XPU #2980

Open
whitneywhtsang opened this issue Dec 10, 2024 · 4 comments
Open

Port test_min_dot_size to XPU #2980

whitneywhtsang opened this issue Dec 10, 2024 · 4 comments
Labels
enhancement New feature or request tests: ut
Milestone
1.0 [UT and Tutor...

Comments

@whitneywhtsang
Copy link
Contributor

whitneywhtsang commented Dec 10, 2024 •
edited
Loading

UT added in #2978 from upstream commit triton-lang/triton@5700c14.
@whitneywhtsang whitneywhtsang mentioned this issue Dec 10, 2024
Merged
@vlad-penkin vlad-penkin added the enhancement New feature or request label Dec 10, 2024
@etiotto
Copy link
Contributor

etiotto commented Dec 10, 2024

I get this error:

FAILED test_compile_errors.py::test_min_dot_size[dtype0] - TypeError: ASTSource.__init__() got an unexpected keyword argument 'constexprs'

This happens because our version of ASTSource is not up to date. We need https://github.com/triton-lang/triton/pull/5220 first.

@etiotto
Copy link
Contributor

etiotto commented Dec 10, 2024

@whitneywhtsang I see from the log that you have merged but then reverted the PR with the changes we need:

commit 492ea92c05ac2fdde8abf7ded241442f029217ea
Author: Whitney Tsang <[email protected]>
Date:   Tue Dec 10 04:02:08 2024 +0000

    Revert "[FRONTEND] added support for tuples (#5220)"
    
    This reverts commit 9743ec0dca5bbd9dbce20adc3ee273af6b095f94.

What was the reason for reverting that commit ?

@whitneywhtsang
Copy link
Contributor Author

What was the reason for reverting that commit ?

Because it causes UTs failures.

@whitneywhtsang
Copy link
Contributor Author

Depends on #2979.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tests: ut
Projects
None yet
Milestone
1.0 [UT and Tutorials][Triton 3.2] Pa...
Development

No branches or pull requests
3 participants
@whitneywhtsang @etiotto @vlad-penkin