Remove functionality to merge duplicates #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously disabled this functionally unconditionally by setting merge_duplicates=False, but stopped short of removing the code. This commit removes the merge_duplicates variable completely, along with any code unreachable when merge_duplicates is set to False. Signed-off-by: John Pennycook <[email protected]>
laserkelvin
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously disabled this functionally by setting
merge_duplicates=False, but stopped short of removing the code.Related issues
Arguably part of #36 -- all the code removed by this PR was previously unreachable and untested.
Proposed changes
merge_duplicatesbecause it's alwaysFalse._map_filename()because it does nothing whenmerge_duplicates=False.FileInfoandcompute_file_hashbecause they were only used by_map_filename.