Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'start/pause/resume' functionality in perf #67

Open
raviagiri opened this issue Apr 30, 2024 · 5 comments
Open

Add support for 'start/pause/resume' functionality in perf #67

raviagiri opened this issue Apr 30, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@raviagiri
Copy link

What is the problem this feature would solve?

Measuring performance metrics for a) specific application 'phases' or b) during execution of specific code segments or c) during specific 'events' requires the ability to specify start/pause/resume functionality.

What is the feature you are proposing to solve the problem?

add support for start/pause/resume functionality that's in perf since kernel v5.9 and later: https://lore.kernel.org/lkml/[email protected]/ . Specifically, support the --delay, --ctl-fd and --ctl-fd-ack options to delay and to listen for pause and resume commands respectively and add support for sending pause and resume. (I may follow-up with a PR for this)

What alternatives have you considered?

No response

@raviagiri raviagiri added the enhancement New feature or request label Apr 30, 2024
@xwu2intel
Copy link

xwu2intel commented Nov 15, 2024

echo that. Currently, perfspect telemetry can only run for a duration, or there will be no output if interrupted (control-c). How to force stop perfspect telemetry and generate the output collected so far?

@xwu2intel
Copy link

Found a workaround for perfspect metrics:

perfspect metrics &
killall -s SIGINT perf

@harp-intel
Copy link
Contributor

harp-intel commented Nov 18, 2024

SIGINT to perfspect will stop metric collection and produce output files. If not, it's a bug.

@xwu2intel
Copy link

xwu2intel commented Nov 18, 2024

SIGINT to perfspect will stop metric collection and produce output files. If not, it's a bug.

SIGINT to perfspect will stop the metric collection but will not produce any output files.

@harp-intel
Copy link
Contributor

It is working with Ctrl-C in the terminal, but not with 'kill -SIGINT '.

New issue opened: #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants