Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binblockread breaks with USBTMCCommunicator. #28

Open
cgranade opened this issue Apr 2, 2014 · 0 comments
Open

binblockread breaks with USBTMCCommunicator. #28

cgranade opened this issue Apr 2, 2014 · 0 comments
Labels
Milestone

Comments

@cgranade
Copy link
Contributor

cgranade commented Apr 2, 2014

Using the new pure-Python implementation of USB-TMC wrapped by USBTMCCommunicator, the binblockread function now breaks for at least the Rigol DS-1000 series. This seems to be because the instrument returns the entire block at once, rather than buffering it, as is expected by the current binblockread function. My solution to this would be to move the binblockread function into the communicator class, and make the current implementation a default given by the base. I'm not sure that solves the issue, though.

@cgranade cgranade added the bug label Apr 2, 2014
@cgranade cgranade added this to the 1.0 milestone Sep 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant