Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only insert menu options on click #16

Open
trungpham opened this issue Apr 1, 2015 · 2 comments
Open

only insert menu options on click #16

trungpham opened this issue Apr 1, 2015 · 2 comments

Comments

@trungpham
Copy link
Contributor

it seems that the latest version of the code creates the menu options and insert them into the DOM before the user clicks on the trigger.

This is a waste of DOM nodes if there is a lot of menu triggers on the page.

Should only create the DOM when the user clicks on the menu trigger.
@knomedia
Copy link
Contributor

knomedia commented Apr 4, 2015

i believe this was necessary for a11y. can you confirm @mzabriskie?

@dmitry
Copy link

dmitry commented Jul 2, 2015

@mzabriskie ping :neckbeard:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmitry @trungpham @knomedia