Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support/validate for Torch 2.5.1 #354

Open
Tracked by #2623
ktam3 opened this issue Nov 18, 2024 · 5 comments
Open
Tracked by #2623

Add support/validate for Torch 2.5.1 #354

ktam3 opened this issue Nov 18, 2024 · 5 comments
Assignees
Labels

Comments

@ktam3
Copy link

ktam3 commented Nov 18, 2024

Open question: Can we unbound torch going forward?

Needed for:

  • Gaudi 0.19.0
  • ROCm 6.3
@ktam3 ktam3 added epic Larger tracking issue encompassing multiple smaller issues jira and removed epic Larger tracking issue encompassing multiple smaller issues labels Nov 18, 2024
@nathan-weinberg
Copy link
Member

This blocks instructlab/instructlab#2669 as we'll need the training library to support this before we can attempt bumping it in the CLI

Is this ticket itself blocked by #293?

@ktam3 ktam3 changed the title Add support for Torch 2.5 (required for Intel Gaudi 1.19.0) Add support/validate for Torch 2.5 (required for Intel Gaudi 1.19.0) Nov 19, 2024
@ktam3
Copy link
Author

ktam3 commented Dec 10, 2024

@JamesKunstle - should we update this issue to cover new request in ilab repo instructlab/instructlab#2772

@JamesKunstle
Copy link
Contributor

@ktam3 Seems like we need to bump torch for everybody, this issue can just continue to exist, we'll take care of this.

@ktam3
Copy link
Author

ktam3 commented Dec 11, 2024

From the conversation between prarit and nathan in instructlab/instructlab#2669 - it looks like we should be treating version bumps as separate requests for each arch? Does that make sense in the training repo?

@ktam3
Copy link
Author

ktam3 commented Dec 17, 2024

Updating description to make this more general to cover gaudi and ROCm

@ktam3 ktam3 changed the title Add support/validate for Torch 2.5 (required for Intel Gaudi 1.19.0) Add support/validate for Torch 2.5.1 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants