Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(run): change total size type to int32 #505

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix(run): change total size type to int32 #505

merged 2 commits into from
Oct 31, 2024

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Oct 31, 2024 •
edited
Loading

Because

  • int type usage should align with others

This commit

  • change total size type to int32

@linear Linear
Copy link

linear bot commented Oct 31, 2024

INS-6748 Change protobuf data type from int64 to int32

@github-actions GitHub Actions
Copy link

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 31, 2024, 8:08 AM

@donch1989 donch1989 merged commit 68aa7eb into main Oct 31, 2024
1 check passed
@donch1989 donch1989 deleted the jeremy/ins-6748-change-data-type-from-int64-to-int32 branch October 31, 2024 08:18
@droplet-bot droplet-bot mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joremysh @donch1989 @droplet-bot