Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vdp): the type of total_size is wrong #481

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(vdp): the type of total_size is wrong #481

merged 1 commit into from
Oct 3, 2024

Conversation

donch1989
Copy link
Member

Because

  • We initially used int64 for total_size, but it gets converted to a string when using grpc-gateway, which is not ideal.

This commit

  • changes the total_size type to int32 to ensure better compatibility with grpc-gateway and JSON formatting.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 3, 2024, 3:28 AM

@donch1989 donch1989 merged commit e04c859 into main Oct 3, 2024
12 checks passed
@donch1989 donch1989 deleted the huitang/ins-6435 branch October 3, 2024 03:31
@droplet-bot droplet-bot mentioned this pull request Oct 3, 2024
Open
@linear Linear
Copy link

linear bot commented Oct 3, 2024

INS-6435 [Bug] Pipeline Run API return total_size as string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@donch1989