feat(blob): add get object method (#496)

Because another service needs to get the info of the object stored in the blob, Commit adds the get object method --------- Co-authored-by: droplet-bot <[email protected]>
instill-ai · Oct 24, 2024 · d74fca2 · d74fca2
1 parent 7cdbe18
commit d74fca2
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/artifact/artifact/v1alpha/artifact.proto b/artifact/artifact/v1alpha/artifact.proto
@@ -2,6 +2,7 @@ syntax = "proto3";
 
 package artifact.artifact.v1alpha;
 
+import "artifact/artifact/v1alpha/object.proto";
 import "common/healthcheck/v1beta/healthcheck.proto";
 import "common/run/v1alpha/run.proto";
 // Google API
@@ -187,6 +188,18 @@ message ObjectURL {
   optional google.protobuf.Timestamp delete_time = 10;
 }
 
+// GetObjectRequest
+message GetObjectRequest {
+  // object uid
+  string uid = 1;
+}
+
+// GetObjectResponse
+message GetObjectResponse {
+  // object
+  Object object = 1;
+}
+
 // GetObjectURLRequest
 message GetObjectURLRequest {
   // object url uid
@@ -195,7 +208,7 @@ message GetObjectURLRequest {
 
 // GetObjectURLResponse
 message GetObjectURLResponse {
-  // object upload url
+  // object url
   ObjectURL object_url = 1;
 }
 

diff --git a/artifact/artifact/v1alpha/artifact_private_service.proto b/artifact/artifact/v1alpha/artifact_private_service.proto
@@ -28,6 +28,9 @@ service ArtifactPrivateService {
   // Delete a repository tag.
   rpc DeleteRepositoryTag(DeleteRepositoryTagRequest) returns (DeleteRepositoryTagResponse);
 
-  // Get Object Upload URL
+  // Get Object
+  rpc GetObject(GetObjectRequest) returns (GetObjectResponse);
+
+  // Get Object URL
   rpc GetObjectURL(GetObjectURLRequest) returns (GetObjectURLResponse);
 }
diff --git a/openapiv2/artifact/service.swagger.yaml b/openapiv2/artifact/service.swagger.yaml
@@ -1215,11 +1215,19 @@ definitions:
         allOf:
           - $ref: '#/definitions/v1alphaObject'
     title: GetObjectDownloadURLResponse
+  v1alphaGetObjectResponse:
+    type: object
+    properties:
+      object:
+        title: object
+        allOf:
+          - $ref: '#/definitions/v1alphaObject'
+    title: GetObjectResponse
   v1alphaGetObjectURLResponse:
     type: object
     properties:
       objectUrl:
-        title: object upload url
+        title: object url
         allOf:
           - $ref: '#/definitions/v1alphaObjectURL'
     title: GetObjectURLResponse