Feat/middleware #36
Draft
Feat/middleware #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/storyofams/next-password-protect/5DZY4ph3wXxeso5LRC933GKam9Vp [Deployment for bdbfe9e failed] |
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 11 +4
Lines 123 172 +49
Branches 47 68 +21
=========================================
+ Hits 123 172 +49
Continue to review full report at Codecov.
|
|
Looks good, why no merge? |
bikkimahato
reviewed
Feb 7, 2022
Comment on lines
+31
to
+33
| // jest | ||
| // .spyOn(api, 'PasswordChecker') | ||
| // .mockImplementationOnce(() => ({ check } as any)); |
There was a problem hiding this comment.
Commented code should not be pushed to Github.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the password checking using Next middleware.
Also exports the password checking logic in a separate class PasswordChecker, so it can be used on its own.
Closes #25