From d16f16df07f446cc7f3137fd1ca14fe4ecaaac86 Mon Sep 17 00:00:00 2001 From: WiemKhlifi Date: Mon, 2 Dec 2024 11:36:16 +0100 Subject: [PATCH] chore: set the default aggregate_rewards to True --- mava/configs/env/connector.yaml | 4 ++-- mava/configs/env/lbf.yaml | 4 ++-- mava/configs/env/vector-connector.yaml | 4 ++-- mava/wrappers/jumanji.py | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/mava/configs/env/connector.yaml b/mava/configs/env/connector.yaml index 7d4bd5285..5e77cac6a 100644 --- a/mava/configs/env/connector.yaml +++ b/mava/configs/env/connector.yaml @@ -6,8 +6,8 @@ defaults: env_name: Connector # Used for logging purposes. -# Choose whether to aggregate individual rewards into a shared team reward or not -aggregate_rewards: False # If True, use the list of individual rewards. +# Choose whether to aggregate individual rewards into a shared team reward or not. +aggregate_rewards: True # Defines the metric that will be used to evaluate the performance of the agent. # This metric is returned at the end of an experiment and can be used for hyperparameter tuning. diff --git a/mava/configs/env/lbf.yaml b/mava/configs/env/lbf.yaml index bff933140..dc130e312 100644 --- a/mava/configs/env/lbf.yaml +++ b/mava/configs/env/lbf.yaml @@ -6,8 +6,8 @@ defaults: env_name: LevelBasedForaging # Used for logging purposes. -# Choose whether to aggregate individual rewards into a shared team reward or not -aggregate_rewards: False # If True, use the list of individual rewards. +# Choose whether to aggregate individual rewards into a shared team reward or not. +aggregate_rewards: True # Defines the metric that will be used to evaluate the performance of the agent. # This metric is returned at the end of an experiment and can be used for hyperparameter tuning. diff --git a/mava/configs/env/vector-connector.yaml b/mava/configs/env/vector-connector.yaml index 6df2583e0..01f9312b5 100644 --- a/mava/configs/env/vector-connector.yaml +++ b/mava/configs/env/vector-connector.yaml @@ -6,8 +6,8 @@ defaults: env_name: VectorConnector # Used for logging purposes. -# Choose whether to aggregate individual rewards into a shared team reward or not -aggregate_rewards: True # If True, use the list of individual rewards. +# Choose whether to aggregate individual rewards into a shared team reward or not. +aggregate_rewards: True # Defines the metric that will be used to evaluate the performance of the agent. # This metric is returned at the end of an experiment and can be used for hyperparameter tuning. diff --git a/mava/wrappers/jumanji.py b/mava/wrappers/jumanji.py index 5bf578845..443e37d38 100644 --- a/mava/wrappers/jumanji.py +++ b/mava/wrappers/jumanji.py @@ -180,7 +180,7 @@ def __init__( self, env: LevelBasedForaging, add_global_state: bool = False, - aggregate_rewards: bool = False, + aggregate_rewards: bool = True, ): super().__init__(env, add_global_state) self._env: LevelBasedForaging @@ -244,7 +244,7 @@ class ConnectorWrapper(JumanjiMarlWrapper): """ def __init__( - self, env: Connector, add_global_state: bool = False, aggregate_rewards: bool = False + self, env: Connector, add_global_state: bool = False, aggregate_rewards: bool = True ): super().__init__(env, add_global_state) self._env: Connector @@ -365,7 +365,7 @@ class VectorConnectorWrapper(JumanjiMarlWrapper): """ def __init__( - self, env: Connector, add_global_state: bool = False, aggregate_rewards: bool = False + self, env: Connector, add_global_state: bool = False, aggregate_rewards: bool = True ): self.fov = 2 super().__init__(env, add_global_state)