Skip to content

Commit

Permalink
chore: set the default aggregate_rewards to True
Browse files Browse the repository at this point in the history
  • Loading branch information
WiemKhlifi committed Dec 2, 2024
1 parent 59c53f3 commit d16f16d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions mava/configs/env/connector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ defaults:

env_name: Connector # Used for logging purposes.

# Choose whether to aggregate individual rewards into a shared team reward or not
aggregate_rewards: False # If True, use the list of individual rewards.
# Choose whether to aggregate individual rewards into a shared team reward or not.
aggregate_rewards: True

# Defines the metric that will be used to evaluate the performance of the agent.
# This metric is returned at the end of an experiment and can be used for hyperparameter tuning.
Expand Down
4 changes: 2 additions & 2 deletions mava/configs/env/lbf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ defaults:

env_name: LevelBasedForaging # Used for logging purposes.

# Choose whether to aggregate individual rewards into a shared team reward or not
aggregate_rewards: False # If True, use the list of individual rewards.
# Choose whether to aggregate individual rewards into a shared team reward or not.
aggregate_rewards: True

# Defines the metric that will be used to evaluate the performance of the agent.
# This metric is returned at the end of an experiment and can be used for hyperparameter tuning.
Expand Down
4 changes: 2 additions & 2 deletions mava/configs/env/vector-connector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ defaults:

env_name: VectorConnector # Used for logging purposes.

# Choose whether to aggregate individual rewards into a shared team reward or not
aggregate_rewards: True # If True, use the list of individual rewards.
# Choose whether to aggregate individual rewards into a shared team reward or not.
aggregate_rewards: True

# Defines the metric that will be used to evaluate the performance of the agent.
# This metric is returned at the end of an experiment and can be used for hyperparameter tuning.
Expand Down
6 changes: 3 additions & 3 deletions mava/wrappers/jumanji.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def __init__(
self,
env: LevelBasedForaging,
add_global_state: bool = False,
aggregate_rewards: bool = False,
aggregate_rewards: bool = True,
):
super().__init__(env, add_global_state)
self._env: LevelBasedForaging
Expand Down Expand Up @@ -244,7 +244,7 @@ class ConnectorWrapper(JumanjiMarlWrapper):
"""

def __init__(
self, env: Connector, add_global_state: bool = False, aggregate_rewards: bool = False
self, env: Connector, add_global_state: bool = False, aggregate_rewards: bool = True
):
super().__init__(env, add_global_state)
self._env: Connector
Expand Down Expand Up @@ -365,7 +365,7 @@ class VectorConnectorWrapper(JumanjiMarlWrapper):
"""

def __init__(
self, env: Connector, add_global_state: bool = False, aggregate_rewards: bool = False
self, env: Connector, add_global_state: bool = False, aggregate_rewards: bool = True
):
self.fov = 2
super().__init__(env, add_global_state)
Expand Down

0 comments on commit d16f16d

Please sign in to comment.