Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pow.py #125

Closed
wants to merge 4 commits into from
Closed

Create pow.py #125

wants to merge 4 commits into from

Conversation

HenokB
Copy link

@HenokB HenokB commented Oct 5, 2022 •
edited by sabderemane
Loading

Please fill in this pull request template before submitting

1. This pull request resolves #126

2. Description

(Write description of your changes here)

3. Fill in checklist by marking [x]

  • I've read the CONTRIBUTING.md
  • I was assigned to this issue
  • My code is formatted using required linting
  • I've run my code locally and checked it works

sabderemane
sabderemane requested changes Oct 6, 2022
View reviewed changes
Copy link
Member

@sabderemane sabderemane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HenokB for your contribution 😄 There are few suggestions suggested to improve the tutorial. There are also some errors from the linter you can see here. Don't hesite to read the CONTRIBUTING guide to fix those issues.

common-built-in-functions/pow.py Outdated Show resolved Hide resolved
common-built-in-functions/pow.py Outdated Show resolved Hide resolved
common-built-in-functions/pow.py Show resolved Hide resolved
common-built-in-functions/pow.py Show resolved Hide resolved
common-built-in-functions/pow.py Outdated Show resolved Hide resolved
HenokB and others added 3 commits October 6, 2022 23:09
@HenokB
Copy link
Author

HenokB commented Oct 6, 2022

Thanks and I've applied all your suggestions.

sabderemane
sabderemane reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@sabderemane sabderemane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing only the linter errors and after that it will be okay

@sabderemane sabderemane added the change required before merge! Make the change requested in the PR comment label Oct 16, 2022
@HenokB
Copy link
Author

HenokB commented Oct 21, 2022

linter
what kind of linter?

@sabderemane
Copy link
Member

The flake8 linter, one of the check failing
You can see here. Don't hesitate to read the CONTRIBUTING guide to fix those issues.

@sabderemane
Copy link
Member

@HenokB any news on that ?

@funbeedev
Copy link
Member

@sabderemane I'll add the hacktoberfest-accepted label for now.
@HenokB We'd appreciate if you made the requested changes soon :)

@funbeedev funbeedev added the hacktoberfest-accepted accept for hacktoberfest label Oct 31, 2022
@HenokB HenokB closed this by deleting the head repository Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabderemane sabderemane sabderemane requested changes

Assignees
No one assigned
Labels
change required before merge! Make the change requested in the PR comment hacktoberfest-accepted accept for hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tutorial] Add pow tutorial
3 participants
@HenokB @sabderemane @funbeedev