Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream pidstore #1579

Closed
kaplun opened this issue Sep 19, 2016 · 1 comment
Closed

Upstream pidstore #1579

kaplun opened this issue Sep 19, 2016 · 1 comment
Milestone
Invenio 3 is depl...

Comments

@kaplun
Copy link
Contributor

kaplun commented Sep 19, 2016

We are currently using a forked version of pidstore due to: inveniosoftware/invenio-pidstore#63 which is not yet been integrated due to missing proof that this hasn't a performance impact on MySQL.

  • Is there any volunteer to run such a benchmark? @jacquerie maybe it's something you can quickly sketch up with a notebook?
  • Alternatively in order to remove our fork we should pick up shorter PIDs and introduce a translation mapping.
@kaplun
Copy link
Contributor Author

kaplun commented Sep 19, 2016

Putting it Invenio 3 is deployed on labs.inspirehep.net milestone because this choice might have an impact on DB structure. And since there is no upgrader for models at the model I would like to minimize the number of table changes we are going to have in the near future.

kaplun added a commit to kaplun/inspire-next that referenced this issue Sep 28, 2016
@kaplun
general: upstream invenio-pidstore
3f74594 
* No longer uses INSPIRE fork of invenio-pidstore.

* Introduces new get_pid_type_for() helper to map from endpoints
  to corresponding pid_types, now that pid_types are constrained in
  length.
  (closes inspirehep#1579)

Signed-off-by: Samuele Kaplun <[email protected]>
@kaplun kaplun mentioned this issue Sep 28, 2016
Closed
kaplun added a commit to kaplun/inspire-next that referenced this issue Sep 28, 2016
@kaplun
general: upstream invenio-pidstore
fec6e4a 
* No longer uses INSPIRE fork of invenio-pidstore.

* Introduces new get_pid_type_for() and get_endpoint_from_pid_type()
  helpers to map between endpoints and the corresponding pid_types,
  now that pid_types are constrained in length. (closes inspirehep#1579)

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/inspire-next that referenced this issue Sep 28, 2016
@kaplun
general: upstream invenio-pidstore
89a4ce8 
* No longer uses INSPIRE fork of invenio-pidstore.

* Introduces new get_pid_type_for() and get_endpoint_from_pid_type()
  helpers to map between endpoints and the corresponding pid_types,
  now that pid_types are constrained in length. (closes inspirehep#1579)

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/inspire-next that referenced this issue Sep 28, 2016
@kaplun
general: upstream invenio-pidstore
2d5874e 
* No longer uses INSPIRE fork of invenio-pidstore.

* Introduces new get_pid_type_for() and get_endpoint_from_pid_type()
  helpers to map between endpoints and the corresponding pid_types,
  now that pid_types are constrained in length. (closes inspirehep#1579)

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/inspire-next that referenced this issue Sep 29, 2016
@kaplun
general: upstream invenio-pidstore
0ff6af8 
* No longer uses INSPIRE fork of invenio-pidstore.

* Introduces new get_pid_type_for() and get_endpoint_from_pid_type()
  helpers to map between endpoints and the corresponding pid_types,
  now that pid_types are constrained in length. (closes inspirehep#1579)

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/inspire-next that referenced this issue Oct 11, 2016
@kaplun
general: upstream invenio-pidstore
02b4651 
* No longer uses INSPIRE fork of invenio-pidstore.

* Introduces new get_pid_type_for() and get_endpoint_from_pid_type()
  helpers to map between endpoints and the corresponding pid_types,
  now that pid_types are constrained in length. (closes inspirehep#1579)

Signed-off-by: Samuele Kaplun <[email protected]>
@jacquerie jacquerie mentioned this issue Oct 28, 2016
Merged
@jacquerie jacquerie removed their assignment Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Invenio 3 is deployed on labs.inspire...
Development

Successfully merging a pull request may close this issue.

general: upstream invenio-pidstore kaplun/inspire-next
2 participants
@kaplun @jacquerie