Use class instead React.createClass #94
Conversation
krvital
changed the title
src/index.js
Outdated
| } | ||
| }, | ||
|
|
||
| class MaskedInput extends React.Component { |
There was a problem hiding this comment.
Should probably add babel to the build pipeline?
Pretty sure shipping pure ES6 will break everyone's builds.
There was a problem hiding this comment.
Isn't nwb generating a UMD and a modules build? Doesn't this already get transformed in the UMD build?
There was a problem hiding this comment.
Sure, npm run build do all the things
|
|
||
| render() { | ||
| var ref = r => this.input = r | ||
| var ref = r => { this.input = r } |
There was a problem hiding this comment.
should get all the var's to const and let as appropriate while you're at it
There was a problem hiding this comment.
es5 to es6 was not my purpose, I just wanted to avoid React warnings. I think it will be better to do these things in other PR, cause this PR relates to React.createClass only
|
So, where is the maintainer? |
|
I get the feeling the maintainer has lost interest in this project? Should we fork a new project? |
|
I've tried to contact the developer via email and on response there either, might be worth forking and creating a new npm package? |
|
@freaksauce any news about create a fork? |
| @@ -32,7 +32,8 @@ | |||
| "inputmask-core": "^2.1.1" | |||
| }, | |||
| "peerDependencies": { | |||
| "react": "0.14.x || 15.x.x" | |||
| "react": "0.14.x || 15.x.x", | |||
There was a problem hiding this comment.
prop-types requires React ^0.14.9 or React ^15.3.0
|
I'm not sure did I do it in the right way, but I've published my version of fork: react-maskedinput-updated |
|
@insin I think we're all waiting for this one. 😕 |
Use class instead React.createClass and use prop-types package instead React.PropTypes to prevent deprecation warning fix #70 fix #93