Browser Bundles links not working

[hugooliveirad]

These links aren't working:

• https://npmcdn.com/[email protected]/umd/react-maskedinput.js
• https://npmcdn.com/[email protected]/umd/react-maskedinput.min.js

README.md point to them at the Browser Bundle section

[iamdustan]

Oops. @bpugh it seems like we need to keep the compiled build in the repo for that? Is that a requirement of npmcdn?

[iamdustan]

At first glance of npmcdn it looks like the dist should be published to npm. Can anyone verify that?

[bpugh]

According to npmcdn docs they can be published under umd or dist folder.

[jquense]

ya it wants a path to a browser dist build. its abit annoying to keep in the repo but probably worth it for this use case ?

[iamdustan]

Looking at the react-router repo itself, I didn’t see a dist/umd directory (unless I looked in the wrong place somehow). It seemed like it could just be published with that. I’d take publishing umd builds to npm over GH personally, but am open to popular opinion.

[bpugh]

Yeah the whole point of npmcdn is that you only need to publish the dist files to npm and it pulls them in automagically

[jquense]

oops yeah too early for me still. yeah we should only need to publish the dist files for npmcdn, no need to keep them in the repo

[iamdustan]

Preparing to publish 3.1.1 with dist in npm.

[bpugh]

Yeah sorry should thought about that we would need to publish a new version to npm once we made that change.

[iamdustan]

3.1.1 published. Closed by eff2ae6

• https://npmcdn.com/[email protected]/umd/react-maskedinput.js
• https://npmcdn.com/[email protected]/umd/react-maskedinput.min.js

[iamdustan]

Thanks for reporting @hugobessaa

[hugooliveirad]

Thanks for fixing that 😄!