-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct SERREAS derivation in ael03 #284
base: main
Are you sure you want to change the base?
Conversation
Unit Tests Summary340 tests 251 ✅ 1m 3s ⏱️ For more details on these failures, see this check. Results for commit 481df95. ♻️ This comment has been updated with latest results. |
Signed-off-by: Davide Garolini <[email protected]>
Co-authored-by: Pawel Rucki <[email protected]> Signed-off-by: Davide Garolini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few small suggestions, and can you please update the snapshot as well? Then it should be good to go!
Co-authored-by: Emily de la Rua <[email protected]> Signed-off-by: Davide Garolini <[email protected]>
Co-authored-by: Emily de la Rua <[email protected]> Signed-off-by: Davide Garolini <[email protected]>
Co-authored-by: Emily de la Rua <[email protected]> Signed-off-by: Davide Garolini <[email protected]>
hi @Melkiades , can you update the snapshot please. Thank you! |
hey @Melkiades , can you take a look at this again? the topleft is now different? |
Fix coming!! |
Fixes #269