Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct SERREAS derivation in ael03 #284

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Melkiades
Copy link
Contributor

Fixes #269

@Melkiades Melkiades added the sme label Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Unit Tests Summary

340 tests   251 ✅  1m 3s ⏱️
135 suites   88 💤
  1 files      1 ❌

For more details on these failures, see this check.

Results for commit 481df95.

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu assigned BFalquet and khatril and unassigned BFalquet Nov 18, 2024
Co-authored-by: Pawel Rucki <[email protected]>
Signed-off-by: Davide Garolini <[email protected]>
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small suggestions, and can you please update the snapshot as well? Then it should be good to go!

book/listings/adverse-events/ael03.qmd Outdated Show resolved Hide resolved
book/listings/adverse-events/ael03.qmd Outdated Show resolved Hide resolved
book/listings/adverse-events/ael03.qmd Outdated Show resolved Hide resolved
@shajoezhu
Copy link
Contributor

hi @Melkiades , can you update the snapshot please. Thank you!

@shajoezhu
Copy link
Contributor

hey @Melkiades , can you take a look at this again? the topleft is now different?

@Melkiades
Copy link
Contributor Author

Melkiades commented Nov 27, 2024

hey @Melkiades , can you take a look at this again? the topleft is now different?

Fix coming!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SERREAS derivation in AEL03 needs correction
6 participants