Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps {rmarkdown} minimal version #276

Merged
merged 1 commit into from
May 23, 2024
Merged

Bumps {rmarkdown} minimal version #276

merged 1 commit into from
May 23, 2024

Conversation

averissimo
Copy link
Contributor

Pull Request

Part of https://github.com/insightsengineering/coredev-tasks/issues/546

Necessary bump to overcome a lack of binary on ppm snapshots that causes an error on minimum strategies for scheduled workflows.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2024 •
edited
Loading

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@averissimo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@github-actions GitHub Actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        353     353  0.00%    175-595
R/tm_g_gh_correlationplot.R                564     564  0.00%    227-898
R/tm_g_gh_density_distribution_plot.R      279     279  0.00%    135-464
R/tm_g_gh_lineplot.R                       549     549  0.00%    159-792
R/tm_g_gh_scatterplot.R                    246     246  0.00%    144-442
R/tm_g_gh_spaghettiplot.R                  298     298  0.00%    192-557
R/toggleable_slider.R                      155     155  0.00%    72-244
R/utils-arbitrary_lines.r                  126     126  0.00%    19-176
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   39      39  0.00%    12-83
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2881    2881  0.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 695f922

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

pawelru
pawelru approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is still failing but that is an expected failure. Approved!

@averissimo averissimo merged commit 922cac4 into main May 23, 2024
31 of 33 checks passed
@averissimo averissimo deleted the 546-fix-verdepcheck@main branch May 23, 2024 14:26
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m7pr m7pr m7pr approved these changes

@pawelru pawelru pawelru approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averissimo @pawelru @m7pr