Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify lzstring dev version #8

Merged
merged 2 commits into from
Oct 3, 2024
Merged

specify lzstring dev version #8

merged 2 commits into from
Oct 3, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Oct 3, 2024

This potentially unblocks r-hub checks for packages that use roxy.shinylive, like teal.modules.general

https://github.com/insightsengineering/teal.modules.general/actions/runs/11162904017/job/31028602918#step:8:83

Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is good but not yet complete. For incance R CMD CHECK is going to complain. Can you please also add appropriate parameters to the remaining workflows?

@pawelru
Copy link
Contributor

pawelru commented Oct 3, 2024

Alternatively you can do the Remotes field temporarily. This should sort out everything and it would be easier to remove once the new version became available on CRAN

Copy link
Contributor

github-actions bot commented Oct 3, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------
R/parse_url.R                   12       0  100.00%
R/tag_examplesShinylive.R       72       0  100.00%
TOTAL                           84       0  100.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: c53101b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Unit Tests Summary

 1 files   2 suites   0s ⏱️
13 tests 13 ✅ 0 💤 0 ❌
50 runs  50 ✅ 0 💤 0 ❌

Results for commit c53101b.

♻️ This comment has been updated with latest results.

@pawelru pawelru merged commit efbff0d into main Oct 3, 2024
47 of 48 checks passed
@pawelru pawelru deleted the lzstring-ver@main branch October 3, 2024 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
@m7pr
Copy link
Contributor Author

m7pr commented Oct 4, 2024

Thanks @pawelru

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants