-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance readme; add params to create_shinylive_url; other minor docs … #2
Conversation
Unit Tests Summary 1 files 2 suites 0s ⏱️ Results for commit 717e91f. ♻️ This comment has been updated with latest results. |
Pull request was converted to draft
Code Coverage Summary
Diff against main
Results for commit: 717e91f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new arguments to the create_shinylive_url
works fine.
I only have minor comments, but I also think it might be a good idea to add unit tests for the new arguments.
I have read the CLA Document and I hereby sign the CLA |
mode
andheader
params tocreate_shinylive_url()