-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce package(s) size #87
Comments
Reducing the logo file size is relatively easy (using an online tool reduced the size by 70% to ~500KB). I also think that the size of the logo should be checked, as I found that for formatters is quite big 1299x1501 (compared it with teal logo at teal/man/figures/teal.png of 278x321 it is >20 times bigger). Dimensions of the logos found:
I think that only compressing can be enough, but we should reduce the file size of the logos for rtables and formatters. Checking for objects/datasets not used can be more complicated because it is harder to automate as they might be used internally or by other repositories, and I don't know a good method to automatically extract which objects are datasets from an R package (checking https://pharmaverse.r-universe.dev/datasets, reports 33 datasets from teal.* packages but it is harder to explore) . |
[It has been detected](insightsengineering/nestdevs-tasks#87) that the formatters logo is quite big in comparison to other packages. This PR compress the logo so it no longer takes so much of the package size.
Have a look at the
formatters
:when untared:
ex_
datasets at all. But it might be used elsewhere. There are few packages that are usingex_adlb
but I cannot find any usage ofex_advs
andex_adqs
.Adding this in general task repo to repeat the analysis for multiple packages and find a common solution.
It's important because of:
.tgz
files and order by size.The text was updated successfully, but these errors were encountered: