Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More rename gps to gnss #1243

Closed
wants to merge 1 commit into from
Closed

More rename gps to gnss #1243

wants to merge 1 commit into from

Conversation

rzinke
Copy link
Contributor

@rzinke rzinke commented Jul 29, 2024

Description of proposed changes

Reminders

  • Fix #xxxx
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @rzinke, these new names already exists; and as we discussed before, we want to keep this old names as well for backward compatiability.

@rzinke
Copy link
Contributor Author

rzinke commented Jul 30, 2024

Thanks for the reminder. I had forgotten or misunderstood that we wanted to keep the old variable names (gps_ ) for backward compatibility. Closing this request now.

@rzinke rzinke closed this Jul 30, 2024
@rzinke rzinke deleted the gps_rename branch July 30, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants