Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the duplicate detection for entity all-outbound paths #983

Open
RFSH opened this issue Jul 19, 2023 · 0 comments
Open

Improve the duplicate detection for entity all-outbound paths #983

RFSH opened this issue Jul 19, 2023 · 0 comments
Assignees

Comments

@RFSH
Copy link
Member

RFSH commented Jul 19, 2023

When we're fetching values for a table, we're also adding all the all-outbound paths that the page needs to the same request. This list is computed as part of the Reference.activeList API. In this API, we go over all the different ways that an all-outbound path might be needed (visible columns, wait_for of visible columns, and fkeys in the source-definition).

To ensure we're not adding duplicate join statements, we're adding each unique path only once. This uniqueness check is done by checking the name property, which is populated based on the whole path, including the last column. But the last column doesn't affect the generated request in' entity' paths, so we should only look for the foreign key hops in this case.

@RFSH RFSH self-assigned this Jul 19, 2023
@RFSH RFSH changed the title Fix the duplicate detection for entity all-outbound paths Improve the duplicate detection for entity all-outbound paths Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant