Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the context used for entity array aggregates #857

Open
RFSH opened this issue Sep 1, 2020 · 0 comments
Open

Evaluate the context used for entity array aggregates #857

RFSH opened this issue Sep 1, 2020 · 0 comments
Labels
annotation Anything related the annotations (adding new one or changing existing one) discussion required requires a discussion before moving forward investigation required Requires some initial investigation

Comments

@RFSH
Copy link
Member

RFSH commented Sep 1, 2020

In the code for handling aggregates, we're changing the context to always be compact for the entity array aggregates (and we're ignoring the app context).

This has been done as part of #756 and the following is the reason for it:

I realized that I am using the row_name/ for generating list of row-names in entity array aggregate. After a discussion, we decided to change this to always use the row_name/compact context regardless of its parent reference context.

But the way I implemented this is not limited just to the context used in row_name/<context> and it's affecting other parts of the code that use context. As the code will assume the parent context of compact and will use this context.

For instance, we're using context to figure out whether we should add links to the default row-names that are displayed for entity array aggregates (show_foreign_key_link). And in most deployments, the value of this display annotation property is false (we're turning off links in the compact/tabular views.) So the entity array aggregates won't show links even if they are used in detailed context, and you have to add "show_foreign_key_link": true to your source definition.

So should we still use row_name/compact for the row-name values? and if we do, should the context used for other parts of the function use compact or the parent compact?

@RFSH RFSH added the question label Sep 1, 2020
@RFSH RFSH changed the title Evaluate the context used for entity array aggrgates Evaluate the context used for entity array aggregates Sep 1, 2020
@RFSH RFSH added annotation Anything related the annotations (adding new one or changing existing one) discussion required requires a discussion before moving forward and removed question labels Apr 5, 2022
@jrchudy jrchudy added the investigation required Requires some initial investigation label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation Anything related the annotations (adding new one or changing existing one) discussion required requires a discussion before moving forward investigation required Requires some initial investigation
Projects
None yet
Development

No branches or pull requests

2 participants