Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config object in plot config is confusing alongside plotly.config #165

Open
jrchudy opened this issue Jul 12, 2023 · 0 comments
Open

config object in plot config is confusing alongside plotly.config #165

jrchudy opened this issue Jul 12, 2023 · 0 comments
Labels
discussion required Further information is requested help wanted Extra attention is needed plot

Comments

@jrchudy
Copy link
Member

jrchudy commented Jul 12, 2023

In plot config we have plots[0].config, plots[0].plotly.config, and plots[0].plotly.layout. These 3 properties are used to control the display and layout of plotly. Both of layout and config inside of plotly are passed directly to plotly. plots[0].config is used to override properties in plotly.layout for further customization of the plot display.

We have 2 options:

  1. plots[0].config can be renamed to better communicate that it is overriding properties in plotly.layout
  2. move options in plots[0].config into plotly.layout and have a list in plot code to check for them in plotly.layout to then apply the expected functionality for the custom properties

Notes:

  • verify what all properties in plots[0].config do. Do they all overwrite values in plotly.layout? Are there any other cases?
  • clean up plots[0].config to remove properties that were deprecated when plotly.layout was added. This will simplify the above note
@jrchudy jrchudy added help wanted Extra attention is needed plot labels Jul 12, 2023
@jrchudy jrchudy added the discussion required Further information is requested label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion required Further information is requested help wanted Extra attention is needed plot
Projects
None yet
Development

No branches or pull requests

1 participant