Migrate the remaining specs and remove protractor related files #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- explicitly mention nodejs versions that we said we're supporting in pacakge.json - run on any push (similar to ermrestjs) - reduce the timeout
jrchudy
reviewed
Sep 13, 2024
test/e2e/specs/default-config/recordedit/immutable-inputs.spec.ts
Outdated
Show resolved
Hide resolved
jrchudy
reviewed
Sep 13, 2024
test/e2e/specs/default-config/recordedit/immutable-inputs.spec.ts
Outdated
Show resolved
Hide resolved
jrchudy
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the last two remaining specs:
immutable-inputs.spec.jsis nowimmutable-spec.ts.submission-disabled.spec.jscontent was moved toerrors.spec.ts.Apart from removing protractor related files, I also added test retries to the histogram spec given how flaky it is.