Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload a file again but with new filename #2164

Closed
jrchudy opened this issue Mar 30, 2022 · 2 comments
Closed

Upload a file again but with new filename #2164

jrchudy opened this issue Mar 30, 2022 · 2 comments
Assignees
Labels
bug hatrac Anything related to hatrac/uploader recordedit

Comments

@jrchudy
Copy link
Member

jrchudy commented Mar 30, 2022

If a file is being uploaded to hatrac with a new filename, but the file already exists, the hatrac content disposition is not being updated to reflect the new filename. The filename is being set properly in ermrest in this case.

Currently if chaise detects the file exists already, the job is marked complete and the next file is uploaded.

The content disposition in hatrac should be consistent with the filename information that we store in ermrest.

@RFSH RFSH added the bug label Apr 1, 2022
@RFSH
Copy link
Member

RFSH commented Apr 1, 2022

#1949 is not directly related but is talking about how we handle filenames.

Both can be done by adding a new annotation that overrides the default behavior of content-disposition. By,

We might want to allow setting this annotation globally (per schema, or catalog).

@RFSH RFSH added hatrac Anything related to hatrac/uploader discussion required requires a discussion before moving forward investigation required Requires some initial investigation and removed discussion required requires a discussion before moving forward labels Apr 5, 2022
@RFSH RFSH added the discussion required requires a discussion before moving forward label Jul 6, 2023
@jrchudy jrchudy linked a pull request Mar 20, 2024 that will close this issue
@jrchudy jrchudy removed discussion required requires a discussion before moving forward investigation required Requires some initial investigation labels Mar 20, 2024
@jrchudy jrchudy closed this as completed Mar 22, 2024
@jrchudy
Copy link
Member Author

jrchudy commented Mar 22, 2024

Changes were merged in ermrestJS as part of PR #1009 to update the content-disposition when the file already exists in hatrac but the name is different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug hatrac Anything related to hatrac/uploader recordedit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants