From 302f006fcf15c97fc76ce486db95ba7f11652cb6 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 3 Dec 2024 13:18:10 -0800 Subject: [PATCH] Bump @playwright/test from 1.48.2 to 1.49.0 (#2586) * Bump @playwright/test from 1.48.2 to 1.49.0 Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.48.2 to 1.49.0. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](https://github.com/microsoft/playwright/compare/v1.48.2...v1.49.0) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] * use the new chromium headless mode --------- Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aref Shafaei --- Makefile | 5 ++-- package-lock.json | 28 ++++++++++++---------- test/e2e/setup/playwright.configuration.ts | 17 +++++++++++-- test/e2e/utils/constants.ts | 2 +- 4 files changed, 34 insertions(+), 18 deletions(-) diff --git a/Makefile b/Makefile index bd02e661d..7f8e75bea 100644 --- a/Makefile +++ b/Makefile @@ -108,7 +108,7 @@ ALL_MANUAL_TESTS=$(Manualrecordset) define make_test rc=0; \ for file in $(1); do \ - npx playwright test --project=chrome $(2) --config $$file || rc=1; \ + npx playwright test --project=chromium $(2) --config $$file || rc=1; \ done; \ exit $$rc; endef @@ -400,10 +400,11 @@ npm-install-modules: # install packages needed for production and development (including testing) # --include=dev makes sure to ignore NODE_ENV and install everything +# --no-shell: https://github.com/microsoft/playwright/issues/33566 .PHONY: npm-install-all-modules npm-install-all-modules: @npm clean-install --include=dev - @npx playwright install --with-deps + @npx playwright install --with-deps --no-shell # for test cases we have to make sure we're installing dev dependencies and playwright is installed .PHONY: deps-test diff --git a/package-lock.json b/package-lock.json index 581b292c4..c41c55485 100644 --- a/package-lock.json +++ b/package-lock.json @@ -47,7 +47,7 @@ }, "devDependencies": { "@isrd-isi-edu/ermrest-data-utils": "^0.0.7", - "@playwright/test": "*", + "@playwright/test": "latest", "@typescript-eslint/eslint-plugin": "~7.18.0", "@typescript-eslint/parser": "~7.18.0", "chance": "x", @@ -2509,12 +2509,12 @@ } }, "node_modules/@playwright/test": { - "version": "1.48.2", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.48.2.tgz", - "integrity": "sha512-54w1xCWfXuax7dz4W2M9uw0gDyh+ti/0K/MxcCUxChFh37kkdxPdfZDw5QBbuPUJHr1CiHJ1hXgSs+GgeQc5Zw==", + "version": "1.49.0", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.49.0.tgz", + "integrity": "sha512-DMulbwQURa8rNIQrf94+jPJQ4FmOVdpE5ZppRNvWVjvhC+6sOeo28r8MgIpQRYouXRtt/FCCXU7zn20jnHR4Qw==", "dev": true, "dependencies": { - "playwright": "1.48.2" + "playwright": "1.49.0" }, "bin": { "playwright": "cli.js" @@ -6158,8 +6158,10 @@ }, "node_modules/fsevents": { "version": "2.3.2", + "resolved": "https://registry.npmjs.org/fsevents/-/fsevents-2.3.2.tgz", + "integrity": "sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA==", "dev": true, - "license": "MIT", + "hasInstallScript": true, "optional": true, "os": [ "darwin" @@ -8410,12 +8412,12 @@ } }, "node_modules/playwright": { - "version": "1.48.2", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.48.2.tgz", - "integrity": "sha512-NjYvYgp4BPmiwfe31j4gHLa3J7bD2WiBz8Lk2RoSsmX38SVIARZ18VYjxLjAcDsAhA+F4iSEXTSGgjua0rrlgQ==", + "version": "1.49.0", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.49.0.tgz", + "integrity": "sha512-eKpmys0UFDnfNb3vfsf8Vx2LEOtflgRebl0Im2eQQnYMA4Aqd+Zw8bEOB+7ZKvN76901mRnqdsiOGKxzVTbi7A==", "dev": true, "dependencies": { - "playwright-core": "1.48.2" + "playwright-core": "1.49.0" }, "bin": { "playwright": "cli.js" @@ -8428,9 +8430,9 @@ } }, "node_modules/playwright-core": { - "version": "1.48.2", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.48.2.tgz", - "integrity": "sha512-sjjw+qrLFlriJo64du+EK0kJgZzoQPsabGF4lBvsid+3CNIZIYLgnMj9V6JY5VhM2Peh20DJWIVpVljLLnlawA==", + "version": "1.49.0", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.49.0.tgz", + "integrity": "sha512-R+3KKTQF3npy5GTiKH/T+kdhoJfJojjHESR1YEWhYuEKRVfVaxH3+4+GvXE5xyCngCxhxnykk0Vlah9v8fs3jA==", "dev": true, "bin": { "playwright-core": "cli.js" diff --git a/test/e2e/setup/playwright.configuration.ts b/test/e2e/setup/playwright.configuration.ts index 67812bad4..38c9dc5be 100644 --- a/test/e2e/setup/playwright.configuration.ts +++ b/test/e2e/setup/playwright.configuration.ts @@ -86,7 +86,19 @@ const getConfig = (options: TestOptions) => { { name: PW_PROJECT_NAMES.PRETEST, testDir: __dirname, - testMatch: 'playwright.pretest.ts' + testMatch: 'playwright.pretest.ts', + use: { + /** + * To reduce the download size, I've added "no-shell" to the npm-install-all-modules make target. + * so only the new headless mode is available and that's why we need to define the channel. + * + * Once we decided to run the test cases on all browsers, we should see if defining this channel + * causes any issues or not. If it does, we should remove this property from here and "no-shell" from make target. + * + * https://github.com/microsoft/playwright/issues/33566 + */ + channel: 'chromium', + } }, { name: PW_PROJECT_NAMES.CHROME, @@ -94,7 +106,8 @@ const getConfig = (options: TestOptions) => { use: { ...devices['Desktop Chrome'], ...extraBrowserParams, - permissions: ['clipboard-read', 'clipboard-write'] + permissions: ['clipboard-read', 'clipboard-write'], + channel: 'chromium', // https://github.com/microsoft/playwright/issues/33566 }, }, // { diff --git a/test/e2e/utils/constants.ts b/test/e2e/utils/constants.ts index 7ceb83363..354d1d846 100644 --- a/test/e2e/utils/constants.ts +++ b/test/e2e/utils/constants.ts @@ -43,7 +43,7 @@ export const ENTITIES_PATH = 'entities.json'; export enum PW_PROJECT_NAMES { PRETEST = 'pretest', - CHROME = 'chrome', + CHROME = 'chromium', FIREFOX = 'firefox', SAFARI = 'safari' }