Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest meshmode gmsh ingest chain has some problems #414

Open
MTCam opened this issue May 7, 2024 · 1 comment
Open

Newest meshmode gmsh ingest chain has some problems #414

MTCam opened this issue May 7, 2024 · 1 comment

Comments

@MTCam
Copy link
Contributor

MTCam commented May 7, 2024

Thanks @inducer for the new updates to gmsh ingest - bunch of improvement there. There still seems to be a couple of issues with 2D that we should work out before nailing down 3D.

In short, we noticed that previously working mirgecom TPE cases began to fail on gmsh_interop latest update.

Specifically, these old cases all had negatively oriented (clockwise connectivities) elements because that was previously required to make gmsh meshes work in mirgecom. Those meshes can be ingested without error when sending the force_positive_orientation=True option, however they fail to work in mirgecom because this option appears to lose boundary information (see #413 ).

Interestingly, reverting gmsh_interop to its previous version (ed0bff5) allows the old negatively oriented meshes to be read without any errors at all and then they run fine in mirgecom.

I think this issue is effectively demonstrated/reproduced with very simple meshes in #413.

CC: @anderson2981

@MTCam
Copy link
Contributor Author

MTCam commented May 8, 2024

One potential fix is propagating the face_vertex_indices_to_tags map through to the element flipper. See (illinois-ceesd#7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant