You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By deprecating it and adding an underscored version.
By "definition", the function is not precise about what local discretization is chosen, which is a bad idea for code that expects consistent results run-to-run. It's currently used in mirgecom here:
Woops! I'll clean that up in this next PR. I stumbled on that function and thought it looked great because it would continue working even without the recursivenodes package.
fwiw, @lukeolson flagged this change in his review and I was able to convince him it was OK. Regardless, here's the "fix" in mirgecom... illinois-ceesd/mirgecom@be86451
By deprecating it and adding an underscored version.
By "definition", the function is not precise about what local discretization is chosen, which is a bad idea for code that expects consistent results run-to-run. It's currently used in mirgecom here:
https://github.com/illinois-ceesd/mirgecom/blob/0a43d11bdf5a21552a875636d8e5cefe23f76ab7/mirgecom/discretization.py#L59-L60=
and its use has also leaked into some grudge examples.
cc @MTCam @lukeolson
The text was updated successfully, but these errors were encountered: