Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]Incorrect overriding stateOptions when reusing a static value as getStateOptions() #244

Open
longquanzheng opened this issue Sep 27, 2024 · 0 comments
Open

[bug]Incorrect overriding stateOptions when reusing a static value as getStateOptions() #244

longquanzheng opened this issue Sep 27, 2024 · 0 comments
Assignees
@longquanzheng
Labels
bug Something isn't working

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Sep 27, 2024 •
edited
Loading

The value will be incorrect if there are two states in a workflow using the same static value for stateOptions(returned from getWorkflowStateOptions(), and one state has waitUntil but another doesnt -- the skipWaitUntil is internally stored in stateOptions and they will be overridden for each other.

This will totally mess up the workflow behavior -- the second state will get a wrong skipWaitUntil value.
@longquanzheng longquanzheng self-assigned this Sep 27, 2024
@longquanzheng longquanzheng added the bug Something isn't working label Oct 7, 2024
@longquanzheng longquanzheng changed the title [bug]Overriding behavior when reusing a static value as getStateOptions() [bug]Incorrect overriding stateOptions when reusing a static value as getStateOptions() Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@longquanzheng longquanzheng

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@longquanzheng