Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the color contrast of pagination links #397

Closed
cindyli opened this issue Sep 17, 2020 · 0 comments
Closed

Improve the color contrast of pagination links #397

cindyli opened this issue Sep 17, 2020 · 0 comments
Assignees
@cindyli
Labels
bug Something isn't working
Milestone
2.3.0

Comments

@cindyli
Copy link
Contributor

cindyli commented Sep 17, 2020 •
edited
Loading

Describe the bug

Running the lighthouse report discovers the color contrast of pagination links is not sufficient on mobile devices. Comparing the implementation on dev site and the figma design, the background color should be 465D8B while the website is using 5879a0. The background color should be adjusted to match the design.

To Reproduce

Steps to reproduce the behavior:

  1. Check the report of "lighthouse CI - Mobile" generated by the lighthouse CI pull request;
  2. Accessibility score of a few pagination links is dropped from 100 to 98.
@cindyli cindyli added the bug Something isn't working label Sep 17, 2020
@cindyli cindyli added this to the 2.3.0 milestone Sep 17, 2020
@cindyli cindyli self-assigned this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindyli cindyli

Labels
bug Something isn't working
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@cindyli