-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Residual mean squares' is property of model not the contrast #122
Comments
Waiting on @nicholst's feedback on the best way to compute this. |
Background:
If we must create a single residual mean squared variance, it seems that the most direct thing is to take the average of the scan-specific variance. For a single variance group, this is just the sum of So! The question: At this point, do we want to support more than one variance group? |
Notes from further reflection: The appropriate sigma squared should be easy to calculate for the multi-group case Where \sigma^2_i is the i-th varcope from It remains to be seen if we want to support multiple groups right now. |
Discussed with @nicholst, @TomMaullin and @AlexBowring, the computation of residual mean square at the second-level needs to be fixed.
https://github.com/incf-nidash/nidmresults-fsl/blob/master/nidmfsl/fsl_exporter/fsl_exporter.py#L806-L809
RMS is property of the model not of a contrast. Actually the contrast number is hard-coded to '1'.
The text was updated successfully, but these errors were encountered: