Replace count_loc.sh with xtask

[joshka]

To run the count_loc now, you can use cargo xtask count-loc instead of
./count_loc.sh.

See https://github.com/matklad/cargo-xtask for more info on
cargo-xtask.

Fixes: #323

[joshka]

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.41%. Comparing base (edcba19) to head (8890610).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   48.41%   48.41%           
=======================================
  Files          10       10           
  Lines        1138     1138           
=======================================
  Hits          551      551           
  Misses        587      587           

Flag	Coverage Δ
wasm32-wasip1	49.00% <ø> (ø)
x86_64-apple-darwin	49.09% <ø> (ø)
x86_64-pc-windows-gnu	48.29% <ø> (ø)
x86_64-unknown-linux-gnu	49.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[ilai-deutel]

Amazing, thank you so much!

[joshka]

Apologies for the rebases here - missed removing the intentional failure code and reverting it back properly (and then got caught by vscode autoformatting)

[joshka]

I'll take a look at the current set of failures a bit later

[joshka]

Rebased and squashed to re-trigger checks, I think the last failure might have been a transient rust nightly issue rather than a true failure. Re-running to confirm.

Edit: looks like not a transient problem.
https://github.com/ilai-deutel/kibi/actions/runs/11852342253/job/33030343047?pr=328

Run mbrobbel/rustfmt-check@master
  with:
    token: ***
    mode: review
    commit-message: Format Rust code using rustfmt
  env:
    CARGO_TERM_COLOR: always
/home/runner/.cargo/bin/cargo +nightly fmt -- --emit json
[]
[]
Error: Unexpected non-whitespace character after JSON at position 2

Locally (latest nightly, on macOS) that command only shows a single [].
Edit: actually it's producing the same output now. I was mistaken

[joshka]

with --package: a different error appears...

Run mbrobbel/rustfmt-check@master
  with:
    token: ***
    mode: review
    args: --package kibi
    commit-message: Format Rust code using rustfmt
  env:
    CARGO_TERM_COLOR: always
/home/runner/.cargo/bin/cargo +nightly fmt --package kibi -- --emit json
[]
Error: Resource not accessible by integration

[joshka]

Raised mbrobbel/rustfmt-check#1137 against the rustfmt check action to try to find out more about the problem.

[joshka]

mbrobbel/rustfmt-check#1137 (comment)

Looks like this is happening on a PR from a forked repo. Depending on the repo configuration the token may not get the required write permissions, resulting in the Resource not accessible by integration error. More info here https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token.

Can you maybe rerun the failed job and select Enable debug logging.?

[ilai-deutel]

Thank you for raising this with the action owner! I added this yesterday to reduce the friction with fmt checks and it worked when I tested it in a different PR, I'm not sure what's going on. I shared the debug logs in the other issue.

[ilai-deutel]

I just saw you modified the CI YAML file. I wonder if this is a security feature, disabling token permissions for non-owners who modify the config files to avoid running arbitrary code with all the permissions.

Could you try maybe adding rustfmt::skip codeblocks in the xtask code as needed, and revert your change to the yaml?

[ilai-deutel]

I disabled mbrobbel/rustfmt-check in the workflow config for now

[joshka]

Rebased on master - all green