Find multiple matches on the same line. #279
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 48.70% 48.56% -0.14%
==========================================
Files 11 11
Lines 1043 1046 +3
==========================================
Hits 508 508
- Misses 535 538 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I fixed the linter error at the expense that parameter names are less suggestive. However I think the comments are insightful enough for the code to be readable. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return Some(current); | ||
| let mut cur = lst.unwrap_or_else(|| (usize::MAX, num_rows.saturating_sub(1))); | ||
| while { | ||
| // TODO: add find backwards on the same line |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
I've realized that my code unfortunately doesn't work for searching backwards on the same line and I can't find a solution that wouldn't break the line count. :( |
I modified find so that it can show multiple matches on the same line.