-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
does work with local container images #33
Comments
Thanks for the info! This is easy addition if you'd want to contribute a PR. Adding variable to defaults with force -value, and then using it at image pull option. |
On the other hand, the whole image pull will soon change due the auto-update feature of podman. Then we don't need this step at all. |
Any update on this? I have the same requirement, and can contribute to the project more broadly via some documentation rather than code. |
Now that the podman has auto update, and I'm personally using it, I feel like this image pull could be removed altogether. How do people feel about it, would it break some workflow for anyone? This issue would get fixed while doing so. |
Sounds good. out with it. maybe a comment somewhere that you recommend using auto update? |
Does this just amount to a documentation update to explain how to use local containers and specify the minimum podman version for the feature to work? Happy to help with documentation once I understand it a little better! |
Sorry to say but I have no use case for this, so perhaps one of you makes a PR so it gets done. I'm happy to merge it. Now that I think again about removing podman ansible module from pulling images, I recall it might break something. Someone had it due they needed to authenticate to registry. If that get's removed, make sure podman authenticates to registry if creds are given. Change is really small anyhow. |
The fix is super simple: To the tasks
add the following to the
|
@Ramblurr will you submit a PR? |
Diving into this again, I'm afraid my proposed fix will prevent pulling of public images when no user/pass is defined. Is that a problem? |
Yes, I'd say so. It needs to pull also if no user auth is required. |
The forcing of container download makes it fail when the containers are build locally - it tries to download from localhost (because podman prefixes local builds with localhost).
changing force to false in the "running single container, ensure we have up to date container image" task does the trick for me.
The text was updated successfully, but these errors were encountered: