Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate fitting and prediction data #6

Open
zhengp0 opened this issue Aug 11, 2023 · 0 comments
Open

Separate fitting and prediction data #6

zhengp0 opened this issue Aug 11, 2023 · 0 comments

Comments

@zhengp0
Copy link
Member

zhengp0 commented Aug 11, 2023

Currently we store fitting and prediction data in one data frame. While this is convenient for our current use, it have several drawbacks

  • We will have data set that has multiple observations per demographics combination. And this will potentially make the prediction step more complicated and expensive than necessary
  • For weave model it requires all data frame doesn't have NaN, and we need to manually set the NaN in the residual where we do not have observation but want prediction to 1.
@zhengp0 zhengp0 mentioned this issue Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant