Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Delete This Game" should have an "Undo" mechanism #394

Open
dfabulich opened this issue Sep 2, 2024 · 1 comment
Open

"Delete This Game" should have an "Undo" mechanism #394

dfabulich opened this issue Sep 2, 2024 · 1 comment
Labels
moderation tools This affects the way moderators do their work

Comments

@dfabulich
Copy link
Collaborator

dfabulich commented Sep 2, 2024

As it stands today, when moderators use the "Delete This Game" feature, this action can't be undone. Even when you opt to merge one game into another, we can't undo it.

The deleter/merger deletes/merges these features:

  • Played games, wishlists, unwishlists
  • Recommended list items
  • Reviews and review comments
  • Cross recommendations
  • Poll votes and comments
  • Competition entries
  • Game news

But the deleter just deletes these things; the merger simply updates all of those rows to change them to point to the new game, with no record that they used to point at an old game.

Furthermore, the merger doesn't merge any simple text fields:

  • Title
  • Author
  • Genre
  • Description
  • Version
  • License
  • Dev system
  • Language
  • Series info

And, of course, the cover art isn't merged, either. (I separately filed #395 that we should merge cover art when the target game doesn't even have cover art.)

All of this data on the deleted game is simply deleted forever, along with its edit history.

@dfabulich dfabulich added the moderation tools This affects the way moderators do their work label Sep 2, 2024
@dfabulich
Copy link
Collaborator Author

dfabulich commented Sep 2, 2024

I think this would be an enormously challenging project; I don't expect that anybody will work on this any time soon. But I would be willing to review a PR (or, perhaps, a series of PRs?) to implement this.

When deleting, I think we'd want/need to move the deleted game and its history to an archive table. (I think it would not be wise to just mark the game as "deleted" and then try to update all of the other code in the entire site to avoid showing deleted games; it would be a neverending source of bugs.)

When merging, we'd need to keep a record of all the metadata that we merged, so we could click a button to put it all back where it came from.

@dfabulich dfabulich changed the title "Delete This Game" merge tool should have an "Undo" mechanism "Delete This Game" should have an "Undo" mechanism Sep 2, 2024
@dfabulich dfabulich transferred this issue from iftechfoundation/ifdb-suggestion-tracker Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moderation tools This affects the way moderators do their work
Projects
None yet
Development

No branches or pull requests

1 participant