Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track tags in game history #377

Open
dfabulich opened this issue Oct 3, 2024 · 3 comments
Open

Track tags in game history #377

dfabulich opened this issue Oct 3, 2024 · 3 comments
Labels
tagging Improvements in IFDB's tags

Comments

@dfabulich
Copy link
Collaborator

Tagging could/should be tracked in game history, so anyone can see who tagged a game and when.

@dfabulich dfabulich added the tagging Improvements in IFDB's tags label Oct 3, 2024
@dfabulich
Copy link
Collaborator Author

If/when we roll this out, I think we might want to write some code to retroactively add in game-history events for added tags. We could either do them fine grained, adding individual fake history events for every added tag, or we could just do one big history event for every game to say that the "system" added these tags to history.

@dfabulich
Copy link
Collaborator Author

I mentioned this on #873, but I wanted to mention it here, too: I think if we do this, it would be fine for anyone to remove tags.

@jtn20
Copy link

jtn20 commented Nov 10, 2024

If tags do become part of game data and history (per this and #915), I think the game history viewer will need enhancement, as tag changes will make game edit history very noisy.
I'd like to be able to continue to see just the changes that affect non-tag bits of game data, as today.
(But, of course, we also need to be able to see a history view that includes tag changes, otherwise we don't have the implicit monitoring abuse from having a public audit trail.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tagging Improvements in IFDB's tags
Projects
None yet
Development

No branches or pull requests

2 participants