Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to search on non-game browse pages #1135

Open
dfabulich opened this issue Nov 15, 2024 · 3 comments
Open

Add a way to search on non-game browse pages #1135

dfabulich opened this issue Nov 15, 2024 · 3 comments
Labels
searches Improvements in IFDB's search functionality

Comments

@dfabulich
Copy link
Collaborator

If you click the Browse link in the header, then click on a non-game search type (list, comp, etc.) there's no obvious way to search for items of that type.

https://ifdb.org/search?browse&comp

@dfabulich dfabulich added the searches Improvements in IFDB's search functionality label Nov 15, 2024
@dfabulich
Copy link
Collaborator Author

I have two ideas on how to do this.

We could just add a search box at the top of browse pages. (Presumably only for non-game browse pages, because the header already has a search box there…?)

Or, we could add a tip box, "Search for competitions". (But tip boxes don't show on mobile #1043 So we'd presumably have to figure out what to do about that.)

@salty-horse
Copy link
Collaborator

I'm for adding the search boxes (which already need some cleanup, because their code is duplicated at the top and bottom of the search page, and there's a big if {} else {} chain that duplicates a lot of code - it needs to be an echo function call)

@salty-horse
Copy link
Collaborator

salty-horse commented Nov 23, 2024

In the browse page, it also shows the "Search tips" box, when there's no way to search. (The "Search tips" headline links to the proper search page)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
searches Improvements in IFDB's search functionality
Projects
None yet
Development

No branches or pull requests

2 participants