Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an error/warning message when using user-specific search filters while logged out #1131

Open
dfabulich opened this issue Nov 14, 2024 · 1 comment
Labels
needs discussion It's not clear how to begin/finish this searches Improvements in IFDB's search functionality

Comments

@dfabulich
Copy link
Collaborator

dfabulich commented Nov 14, 2024

There are a bunch of search filters that only do anything useful if you're logged in:

  • played
  • willplay
  • wontplay
  • reviewed
  • rated

If you use them while logged out, they just silently don't do anything. But perhaps the UI should include a warning about this? An error, instead of search results?

(And what about the search API?)

@dfabulich dfabulich added the searches Improvements in IFDB's search functionality label Nov 14, 2024
@dfabulich
Copy link
Collaborator Author

This would affect the home page's "IFDB recommends" search: played:no willplay:no wontplay:no reviewed:no rated:no

@dfabulich dfabulich added the needs discussion It's not clear how to begin/finish this label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion It's not clear how to begin/finish this searches Improvements in IFDB's search functionality
Projects
None yet
Development

No branches or pull requests

1 participant